[webkit-reviews] review granted: [Bug 174120] Resource Load Statistics: User interaction should always go to top document : [Attachment 314952] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 174120: Resource Load Statistics: User interaction should always go to top
document
https://bugs.webkit.org/show_bug.cgi?id=174120

Attachment 314952: Patch

https://bugs.webkit.org/attachment.cgi?id=314952&action=review




--- Comment #19 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 314952
  --> https://bugs.webkit.org/attachment.cgi?id=314952
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314952&action=review

r=me with comments.

> Source/WebCore/loader/ResourceLoadObserver.cpp:64
> +    ASSERT(m_notificationCallback);

I don't think this assertion is useful, it is already inside
scheduleNotificationIfNeeded();

>
LayoutTests/http/tests/loading/resourceLoadStatistics/user-interaction-in-cross
-origin-sub-frame.html:48
> +<iframe id="testFrame"
src="http://localhost:8000/loading/resourceLoadStatistics/resources/dummy.html"
></iframe>

I would use subFrameOrigin +
"/loading/resourceLoadStatistics/resources/dummy.html" for clarity.

> LayoutTests/platform/mac-wk2/TestExpectations:713
> +# Currently only tests with click, not tap.

Why is this still skipped on iOS-wk2?