[webkit-reviews] review granted: [Bug 174296] [JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not <CR><LF>) as one line terminator : [Attachment 314941] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 174296: [JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not
<CR><LF>) as one line terminator
https://bugs.webkit.org/show_bug.cgi?id=174296

Attachment 314941: Patch

https://bugs.webkit.org/attachment.cgi?id=314941&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 314941
  --> https://bugs.webkit.org/attachment.cgi?id=314941
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314941&action=review

r=me. Thanks for fixing this.	Can you add a test case that covers this?  
Obviously, the need for this patch is not covered by existing tests or we would
have seen it when the change of treatment of /n/r was added.

> Source/JavaScriptCore/ChangeLog:10
> +	   <LF><CR> to <LF><LF>, we still needed to incrase line number by only
one.

typo: /incrase/increase/.