[webkit-reviews] review granted: [Bug 174294] Remove some obsolete WebKitVersionChecks : [Attachment 314939] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Brady Eidson <beidson at apple.com>'s request for
review:
Bug 174294: Remove some obsolete WebKitVersionChecks
https://bugs.webkit.org/show_bug.cgi?id=174294

Attachment 314939: Patch

https://bugs.webkit.org/attachment.cgi?id=314939&action=review




--- Comment #4 from mitz at webkit.org ---
Comment on attachment 314939
  --> https://bugs.webkit.org/attachment.cgi?id=314939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314939&action=review

> Source/WebKit/ios/WebView/WebPDFViewIOS.mm:125
> +    CGFloat height = 2.0f;

Might as well get rid of this constant and inline the value below.

> Source/WebKit/mac/WebView/WebView.mm:2902
> +    settings.setShouldTransformsAffectOverflow(true);
> +    settings.setShouldDispatchJavaScriptWindowOnErrorEvents(true);

Can these settings ever be false after this patch?