[webkit-reviews] review granted: [Bug 174284] media element handle adding source immediately before src. : [Attachment 314900] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 174284: media element handle adding source immediately before src.
https://bugs.webkit.org/show_bug.cgi?id=174284

Attachment 314900: Patch

https://bugs.webkit.org/attachment.cgi?id=314900&action=review




--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 314900
  --> https://bugs.webkit.org/attachment.cgi?id=314900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314900&action=review

r=me (although maybe you want someone with more WebKit media experience to
review)

> Source/WebCore/ChangeLog:9
> +	   Test: media/video-source-before-src.html

The test crashes without the fix!  Yay!

> Source/WebCore/ChangeLog:11
> +	   Adding a soruce causes selectMediaResource block to be enqueued.

Typo:  soruce = > source

> Source/WebCore/ChangeLog:13
> +	   If dataLoadingPermitted prevents creating the m_player but sets the
srcAttr.
> +	   The enqeueud selectMediaResource will be in a bad state, with a
srcAttr but no m_player.

These read best like a single sentence:

    If ... srcAttr, then
    the enqueued ....

Note that "enqueued" is also typoed.

> Source/WebCore/html/HTMLMediaElement.cpp:1328
> +		   LOG(Media, "HTMLMediaElement::selectMediaResource(%p) - has
srcAttr but m_player is not created", this);

Should this be a RELEASE_LOG_ERROR() or at least a LOG_ERROR()?