[webkit-reviews] review denied: [Bug 174233] Add location to NavigationActionData : [Attachment 314894] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 174233: Add location to NavigationActionData
https://bugs.webkit.org/show_bug.cgi?id=174233

Attachment 314894: Patch

https://bugs.webkit.org/attachment.cgi?id=314894&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314894
  --> https://bugs.webkit.org/attachment.cgi?id=314894
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314894&action=review

>
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:80
> +    return FloatPoint(mouseEvent->clientX(), mouseEvent->clientY());

I think this is probably wrong if the event occurred inside an iframe
(clientX/clientY) will be relative to the iframe. clientX/clientY may also not
map simply to root view coordinates because of page scale.