[webkit-reviews] review granted: [Bug 174233] Add location to NavigationActionData : [Attachment 314884] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 174233: Add location to NavigationActionData
https://bugs.webkit.org/show_bug.cgi?id=174233

Attachment 314884: Patch

https://bugs.webkit.org/attachment.cgi?id=314884&action=review




--- Comment #9 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 314884
  --> https://bugs.webkit.org/attachment.cgi?id=314884
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314884&action=review

r=me with some minor tweaks, though this will need a wk2r+ too.

> Source/WebKit2/ChangeLog:11
> +	   * Shared/NavigationActionData.cpp:

ChangeLog entry still references rootViewClickLocation instead of
clickLocationInRootViewCoordinates.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:127
> +    return [NSString stringWithFormat:@"<%@: %p; navigationType = %ld;
syntheticClickType = %ld; position x = %.2f y= %.2f request = %@; sourceFrame =
%@; targetFrame = %@>", NSStringFromClass(self.class), self,

Nit - missing a space between y and =

>
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:111
> +WebCore::FloatPoint
InjectedBundleNavigationAction::clickLocationInRootViewCoordinatesForNavigation
Action(const NavigationAction& navigationAction)

Nit - no need for WebCore:: here.