[webkit-reviews] review granted: [Bug 174219] [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging : [Attachment 314766] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 174219: [iOS DnD] For cross-app drags, 'drop' event handlers are never
invoked if dataTransfer.dropEffect is not set while dragging
https://bugs.webkit.org/show_bug.cgi?id=174219

Attachment 314766: Patch

https://bugs.webkit.org/attachment.cgi?id=314766&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 314766
  --> https://bugs.webkit.org/attachment.cgi?id=314766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314766&action=review

> Source/WebCore/ChangeLog:20
> +	   Tests:
> +	   DataInteractionTests.ExternalSourceHTMLToUploadArea
> +	   DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
> +	   DataInteractionTests.ExternalSourceMoveOperationNotAllowed

We usually have the first test listed after "Tests: " and the rest indented to
align with the first test

> Source/WebCore/page/mac/DragControllerMac.mm:113
> +    // On iOS, UIKit skips the -performDrop invocation altogether if MOVE is
forbidden. Thus,
> +    // if MOVE is not allowed in the drag source operation mask, fall back
to only other allowable
> +    // action, COPY.

Can we wrap lines after "forbidden." instead of after "Thus," to make it read
better?