[webkit-reviews] review denied: [Bug 174239] WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties : [Attachment 314819] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Ansh Shukla
<ansh_shukla at apple.com>'s request for review:
Bug 174239: WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog
configuration properties
https://bugs.webkit.org/show_bug.cgi?id=174239

Attachment 314819: Patch

https://bugs.webkit.org/attachment.cgi?id=314819&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 314819
  --> https://bugs.webkit.org/attachment.cgi?id=314819
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314819&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeaturesPrivate.h:37
> + at property (nonatomic, readonly, getter=_isLocationBarVisible) BOOL
_locationBarVisible WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> + at property (nonatomic, readonly, getter=_areScrollbarsVisible) BOOL
_scrollbarsVisible WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> + at property (nonatomic, readonly, getter=_isFullscreen) BOOL _fullscreen
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> + at property (nonatomic, readonly, getter=_isDialog) BOOL _dialog
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

These should be exposed as NSNumber *s the same way the API bool properties
are.