[webkit-reviews] review denied: [Bug 174233] Add location to NavigationActionData : [Attachment 314792] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 6 22:06:55 PDT 2017
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 174233: Add location to NavigationActionData
https://bugs.webkit.org/show_bug.cgi?id=174233
Attachment 314792: Patch
https://bugs.webkit.org/attachment.cgi?id=314792&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314792
--> https://bugs.webkit.org/attachment.cgi?id=314792
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=314792&action=review
> Source/WebKit2/Shared/NavigationActionData.h:52
> + WebCore::FloatPoint clickPoint;
Would be good if the name said what coordinate space this point lives in. Also,
we'd normally call this a "location".
> Source/WebKit2/UIProcess/API/APINavigationAction.h:66
> + WebCore::FloatPoint clickPoint() const { return
m_navigationActionData.clickPoint; }
Ditto.
> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:54
> + at property (nonatomic, readonly) CGPoint _clickPoint
WK_API_AVAILABLE(ios(11.0));
Ditto.
>
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:75
> + return WebCore::FloatPoint::zero();
This can just be "return { };"
More information about the webkit-reviews
mailing list