[webkit-reviews] review granted: [Bug 174237] Fix bad usage of static variables in ResourceLoadStatisticsStore : [Attachment 314809] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 6 21:36:07 PDT 2017
Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 174237: Fix bad usage of static variables in ResourceLoadStatisticsStore
https://bugs.webkit.org/show_bug.cgi?id=174237
Attachment 314809: Patch
https://bugs.webkit.org/attachment.cgi?id=314809&action=review
--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 314809
--> https://bugs.webkit.org/attachment.cgi?id=314809
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=314809&action=review
> Source/WebKit2/UIProcess/Storage/ResourceLoadStatisticsStore.cpp:263
> + m_timeToLiveUserInteraction = seconds;
These are all fine, but I would have preferred an early return for < 0 in the
original version.
More information about the webkit-reviews
mailing list