[webkit-reviews] review granted: [Bug 173965] Web Inspector: Show all elements currently using a given CSS Canvas : [Attachment 314508] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173965: Web Inspector: Show all elements currently using a given CSS Canvas
https://bugs.webkit.org/show_bug.cgi?id=173965

Attachment 314508: Patch

https://bugs.webkit.org/attachment.cgi?id=314508&action=review




--- Comment #28 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314508
  --> https://bugs.webkit.org/attachment.cgi?id=314508
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314508&action=review

r=me

The tests are failing, so you may have to mark them as flakey. We should really
investigate that.

> Source/JavaScriptCore/inspector/protocol/Canvas.json:79
> +		   { "name": "canvasId", "$ref": "CanvasId", "description":
"Canvas identifier." }

Nit: These descriptions are unnecessary. I think we can probably eliminate them
for most $ref's. If someone needed this description they could get it by
looking at the description of the Type itself.

> LayoutTests/inspector/canvas/css-canvas-clients-expected.txt:13
> +PASS: Client node has valid ID.

Why not just log the selector? Thats more useful.