[webkit-reviews] review granted: [Bug 174196] Write a support script to enable buildbot to upload to S3 : [Attachment 314799] v4, fixed argparser from feedback

[bugzilla-daemon at webkit.org]

Stephanie Lewis <slewis at apple.com> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 174196: Write a support script to enable buildbot to upload to S3
https://bugs.webkit.org/show_bug.cgi?id=174196

Attachment 314799: v4, fixed argparser from feedback

https://bugs.webkit.org/attachment.cgi?id=314799&action=review




--- Comment #8 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 314799
  --> https://bugs.webkit.org/attachment.cgi?id=314799
v4, fixed argparser from feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=314799&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:16
> +    s3.upload_file(archive_path, bucket, key)

I don't like using globals in functions.  Is there a reason to declare s3 as a
global?

> Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:34
> +head, tail = os.path.split(str(args.archive))

Should probably check if args.archive has a value before calling split on it