[webkit-reviews] review granted: [Bug 174186] [WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions : [Attachment 314670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 6 17:47:10 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 174186: [WebIDL] Remove custom bindings for WebGL code dealing with WebGL
extensions
https://bugs.webkit.org/show_bug.cgi?id=174186

Attachment 314670: Patch

https://bugs.webkit.org/attachment.cgi?id=314670&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314670
  --> https://bugs.webkit.org/attachment.cgi?id=314670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314670&action=review

> Source/WebCore/bindings/IDLTypes.h:56
> +#if ENABLE(WEBGL)
> +class WebGLExtension;
> +#endif

It doesn't hurt to forward declare a class outside of guards, does it?


More information about the webkit-reviews mailing list