[webkit-reviews] review granted: [Bug 174220] [GTK][WPE] kill-old-process should kill more webkit related process : [Attachment 314763] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 174220: [GTK][WPE] kill-old-process should kill more webkit related process
https://bugs.webkit.org/show_bug.cgi?id=174220

Attachment 314763: Patch

https://bugs.webkit.org/attachment.cgi?id=314763&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 314763
  --> https://bugs.webkit.org/attachment.cgi?id=314763
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314763&action=review

> Tools/BuildSlaveSupport/kill-old-processes:28
> +def listAllWebKitPrograms(build_dir_bin):

Nit: I might have named this builddir_bin instead.

> Tools/BuildSlaveSupport/kill-old-processes:32
> +	       if os.access(os.path.join(root, file), os.X_OK):

Why do you need to call access?

> Tools/BuildSlaveSupport/kill-old-processes:136
> +	   build_dir_bin = "WebKitBuild/Release/bin" if
os.path.isdir("WebKitBuild/Release/bin") else "WebKitBuild/Debug/bin"

I was going to object to this, but I guess it would be pretty odd if the built
binaries ever differ between release and debug builds, so this seems fine.