[webkit-reviews] review granted: [Bug 174224] WKWebSiteDataStore.removeDataOfTypes should wait until disk cache files are actually removed before invoking completion handler : [Attachment 314773] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 6 16:24:40 PDT 2017


Sam Weinig <sam at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 174224: WKWebSiteDataStore.removeDataOfTypes should wait until disk cache
files are actually removed before invoking completion handler
https://bugs.webkit.org/show_bug.cgi?id=174224

Attachment 314773: patch

https://bugs.webkit.org/attachment.cgi?id=314773&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 314773
  --> https://bugs.webkit.org/attachment.cgi?id=314773
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314773&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:567
> +    keysToRemove.reserveCapacity(keys.size());

You can call reserveInitialCapacity() here.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:581
> +	       RunLoop::main().dispatch([completionHandler =
WTFMove(completionHandler)] {

I think you can just pass completionHandler to RunLoop::main().dispatch() (not
completely sure the types are the same).


More information about the webkit-reviews mailing list