[webkit-reviews] review granted: [Bug 174111] [WK2] ResourceLoadStatistics should batch its writes : [Attachment 314758] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 174111: [WK2] ResourceLoadStatistics should batch its writes
https://bugs.webkit.org/show_bug.cgi?id=174111

Attachment 314758: Patch

https://bugs.webkit.org/attachment.cgi?id=314758&action=review




--- Comment #18 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 314758
  --> https://bugs.webkit.org/attachment.cgi?id=314758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314758&action=review

r=me

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:316
> +	   writeStoreToDisk();

Shouldn't we only do this only if there is a pending write? (i.e. if
m_didScheduleWrite is true) ?

> Source/WebKit2/UIProcess/Storage/ResourceLoadStatisticsStore.h:-110
> -    WTF::Function<void()> m_writePersistentStoreHandler;

This was completely unused? :S