[webkit-reviews] review granted: [Bug 174209] Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab : [Attachment 314734] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 6 10:53:23 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 174209: Web Inspector: Highlight matching canvas element when hovering
contexts in the Resources tab
https://bugs.webkit.org/show_bug.cgi?id=174209

Attachment 314734: Patch

https://bugs.webkit.org/attachment.cgi?id=314734&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314734
  --> https://bugs.webkit.org/attachment.cgi?id=314734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314734&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:43
> +	   this.element.addEventListener("mouseover",
this._handleMouseover.bind(this));
> +	   this.element.addEventListener("mouseout",
this._handleMouseout.bind(this));

Seems we have more occurrences of "handleMouseOver" than "handleMouseover".
Same with `MouseOut`.


More information about the webkit-reviews mailing list