[webkit-reviews] review granted: [Bug 174205] Crash under WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String const&) : [Attachment 314730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 6 10:21:13 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 174205: Crash under
WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String const&)
https://bugs.webkit.org/show_bug.cgi?id=174205

Attachment 314730: Patch

https://bugs.webkit.org/attachment.cgi?id=314730&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 314730
  --> https://bugs.webkit.org/attachment.cgi?id=314730
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314730&action=review

r=me

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:364
> +    return m_statisticsStoragePath.isolatedCopy();

I have to admit I'm shocked that this was necessary -- I guess it's because we
might call this method on the work queue?


More information about the webkit-reviews mailing list