[webkit-reviews] review granted: [Bug 172240] [GStreamer] vid.me videos do not play : [Attachment 314641] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 172240: [GStreamer] vid.me videos do not play
https://bugs.webkit.org/show_bug.cgi?id=172240

Attachment 314641: Patch

https://bugs.webkit.org/attachment.cgi?id=314641&action=review




--- Comment #12 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 314641
  --> https://bugs.webkit.org/attachment.cgi?id=314641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314641&action=review

> Tools/ChangeLog:7
> +	   Build httpsoupsrc again for use in adapative streaming pipelines,
and

"adapative" again :) We should ask the Queen to get it added to the dictionary
already :)

> LayoutTests/http/tests/media/hls/range-request.html:23
> +	       if (window.testRunner) {
> +		   testRunner.dumpAsText();
> +		   testRunner.setAlwaysAcceptCookies(true);
> +		   testRunner.waitUntilDone();
> +	       }
> +
> +	    function playing() {
> +		testRunner.notifyDone();
> +	    }
> +
> +	       function start() {
> +		   video = document.getElementById('video');
> +		video.autoplay = true
> +		waitForEvent("playing", playing);
> +		   video.src = "../resources/hls/range-request-playlist.m3u8";
> +	       }
> +	   </script>

You need to check this indentation.