[webkit-reviews] review granted: [Bug 174188] NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time : [Attachment 314674] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 174188: NewArray in FTLLowerDFGToB3 does not handle speculating on doubles
when having a bad time
https://bugs.webkit.org/show_bug.cgi?id=174188

Attachment 314674: patch

https://bugs.webkit.org/attachment.cgi?id=314674&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 314674
  --> https://bugs.webkit.org/attachment.cgi?id=314674
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314674&action=review

r=me with question addressed.

> Tools/Scripts/run-jsc-stress-tests:862
> -    run("ftl-no-cjit-b3o1", *(FTL_OPTIONS + NO_CJIT_OPTIONS + B3O1_OPTIONS +
optionalTestSpecificOptions))
> +    run("ftl-no-cjit-b3o1", "--useArrayAllocationProfiling=false",
*(FTL_OPTIONS + NO_CJIT_OPTIONS + B3O1_OPTIONS + optionalTestSpecificOptions))

Does it make sense to use --useArrayAllocationProfiling=false for all
ftl-no-cjit-b3o1 tests?  If not, you can just as easily add //@
runFTLNoCJITB3O1("--useArrayAllocationProfiling=false") at the top of the new
test to configure that test alone to use this option.