[webkit-reviews] review granted: [Bug 174155] Upgrade GCC baseline : [Attachment 314679] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 5 21:00:50 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 174155: Upgrade GCC baseline
https://bugs.webkit.org/show_bug.cgi?id=174155

Attachment 314679: Patch

https://bugs.webkit.org/attachment.cgi?id=314679&action=review




--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 314679
  --> https://bugs.webkit.org/attachment.cgi?id=314679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314679&action=review

> Source/WTF/wtf/Compiler.h:98
> +#if !GCC_VERSION_AT_LEAST(5, 3, 0)
> +#error "Please use a newer version of GCC. WebKit requires GCC 5.3.0 or
newer to compile."

This seems pretty arbitrary. Since there's one fewer significant digit in the
version now, it's like setting the requirement at 4.9.3. I would just set it at
5.0 and be done with it.

But this is fine too.


More information about the webkit-reviews mailing list