[webkit-reviews] review denied: [Bug 173982] Web Inspector: GeneralTreeElements should use textContent if the title/subtitle is not a string for filtering : [Attachment 314156] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 5 20:20:35 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173982: Web Inspector: GeneralTreeElements should use textContent if the
title/subtitle is not a string for filtering
https://bugs.webkit.org/show_bug.cgi?id=173982

Attachment 314156: Patch

https://bugs.webkit.org/attachment.cgi?id=314156&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314156
  --> https://bugs.webkit.org/attachment.cgi?id=314156
Patch

r-, it sounds like you can do this in your specific subclass. I think thats
probably preferable to altering the behavior for all TreeElements.


More information about the webkit-reviews mailing list