[webkit-reviews] review granted: [Bug 173569] Web Inspector: Support getting the content of WebGL/WebGL2 contexts : [Attachment 314647] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173569: Web Inspector: Support getting the content of WebGL/WebGL2 contexts
https://bugs.webkit.org/show_bug.cgi?id=173569

Attachment 314647: Patch

https://bugs.webkit.org/attachment.cgi?id=314647&action=review




--- Comment #20 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314647
  --> https://bugs.webkit.org/attachment.cgi?id=314647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314647&action=review

r=me

> Source/WebCore/html/canvas/WebGLRenderingContextBase.h:213
> +    bool getPreventBufferClearForInspector() const { return
m_preventBufferClearForInspector; }

Getter should not have a `get` prefix.

> Source/WebCore/inspector/InspectorCanvasAgent.cpp:160
> +	   gl->setPreventBufferClearForInspector(true);
> +
> +	   ExceptionOr<String> result =
canvasEntry->element->toDataURL(ASCIILiteral("image/png"));
> +
> +	   gl->setPreventBufferClearForInspector(false);

Can you group these right next to the toDataURL line? That is the significant
part to me.