[webkit-reviews] review granted: [Bug 174149] CSSFontStyleValue::isItalic seems a bit bogus. : [Attachment 314662] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 174149: CSSFontStyleValue::isItalic seems a bit bogus.
https://bugs.webkit.org/show_bug.cgi?id=174149

Attachment 314662: Patch

https://bugs.webkit.org/attachment.cgi?id=314662&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 314662
  --> https://bugs.webkit.org/attachment.cgi?id=314662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314662&action=review

> Source/WebCore/ChangeLog:12
> +	   * css/CSSFontStyleValue.h:

Write some words!

> Source/WebCore/css/CSSFontStyleValue.h:50
>      {

Should this be called isItalicOrOblique?

> LayoutTests/editing/execCommand/italicizeByCharacter-normal.html:11
> +<script src=../editing.js language="JavaScript" type="text/JavaScript"
></script>

This is the ugliest <script> I've seen in a long time :)