[webkit-reviews] review granted: [Bug 174175] Make WebKit's public headers on Mac and iOS C++ module safe : [Attachment 314658] Fixes the header files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 5 15:18:53 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 174175: Make WebKit's public headers on Mac and iOS C++ module safe
https://bugs.webkit.org/show_bug.cgi?id=174175

Attachment 314658: Fixes the header files

https://bugs.webkit.org/attachment.cgi?id=314658&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314658
  --> https://bugs.webkit.org/attachment.cgi?id=314658
Fixes the header files

View in context: https://bugs.webkit.org/attachment.cgi?id=314658&action=review

r=me with this change.

> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleList.h:27
> +#import <objc/NSObject.h>

Should this be Foundation/NSObject.h?

> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleListStore.h:27
> +#import <objc/NSObject.h>

ditto


More information about the webkit-reviews mailing list