[webkit-reviews] review granted: [Bug 174174] [WK2] WebsiteDataStore::setResourceLoadStatisticsEnabled() updates processPools the store is not associated with : [Attachment 314655] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 174174: [WK2] WebsiteDataStore::setResourceLoadStatisticsEnabled() updates
processPools the store is not associated with
https://bugs.webkit.org/show_bug.cgi?id=174174

Attachment 314655: Patch

https://bugs.webkit.org/attachment.cgi?id=314655&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 314655
  --> https://bugs.webkit.org/attachment.cgi?id=314655
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314655&action=review

Looks good. r=me.

> Source/WebKit2/UIProcess/WebProcessPool.cpp:1117
> +   
sendToAllProcesses(Messages::WebProcess::SetResourceLoadStatisticsEnabled(enabl
ed));

This is much tidier!

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:1271
> +    for (auto& processPool : processPools())

Idea: processPools() should have a method that takes a lambda and applies it to
each process in the pool.

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:1281
> +    m_resourceLoadStatistics->registerSharedResourceLoadObserver([this]
(const Vector<String>& domainsToRemove, const Vector<String>& domainsToAdd,
bool shouldClearFirst) {

I noticed that 'this' is refcounted. Do we need to capture it in this lambda?