[webkit-reviews] review denied: [Bug 172585] Gracefully handle failures in websockets on wincairo : [Attachment 311211] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied
isaac+webkit at devinesystems.co.nz's request for review:
Bug 172585: Gracefully handle failures in websockets on wincairo
https://bugs.webkit.org/show_bug.cgi?id=172585

Attachment 311211: Patch

https://bugs.webkit.org/attachment.cgi?id=311211&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 311211
  --> https://bugs.webkit.org/attachment.cgi?id=311211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311211&action=review

> Source/WebCore/ChangeLog:3
> +	   Handle failures in websocket on wincairo

This is a great thing.	Sorry I didn't notice this patch earlier.  Let's polish
it up and land it.

> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:283
> +	       callOnMainThread([this, ret] {
> +		   // Check reference count to fix a crash.

This is a bad pattern I think we shouldn't expand upon.  Capture protectedThis
= makeRef(*this) to make sure this isn't deallocated underneath us while
waiting for the lambda to be called on another thread.