[webkit-reviews] review denied: [Bug 174088] [PAL] Helper script to move PAL sources : [Attachment 314458] PATCH.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 5 13:47:01 PDT 2017
Alex Christensen <achristensen at apple.com> has denied Yoshiaki Jitsukawa
<Yoshiaki.Jitsukawa at sony.com>'s request for review:
Bug 174088: [PAL] Helper script to move PAL sources
https://bugs.webkit.org/show_bug.cgi?id=174088
Attachment 314458: PATCH.
https://bugs.webkit.org/attachment.cgi?id=314458&action=review
--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314458
--> https://bugs.webkit.org/attachment.cgi?id=314458
PATCH.
View in context: https://bugs.webkit.org/attachment.cgi?id=314458&action=review
> Tools/Scripts/do-pal-move:50
> +my %movesContemplatedForTheFuture = (
> + "KillRing.h" => "text/KillRing.h",
> + "KillRingNone.cpp" => "text/none/KillRingNone.cpp",
> + "mac/KillRingMac.mm" => "text/mac/KillRingMac.mm",
I don't think we should add this to the repository. Maybe a general move
helper, but not this.
More information about the webkit-reviews
mailing list