[webkit-reviews] review granted: [Bug 116691] [GTK] It should process MouseMoved events when the parent window is not active : [Attachment 314611] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 5 11:46:06 PDT 2017


Tim Horton <thorton at apple.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 116691: [GTK] It should process MouseMoved events when the parent window is
not active
https://bugs.webkit.org/show_bug.cgi?id=116691

Attachment 314611: Patch

https://bugs.webkit.org/attachment.cgi?id=314611&action=review




--- Comment #26 from Tim Horton <thorton at apple.com> ---
Comment on attachment 314611
  --> https://bugs.webkit.org/attachment.cgi?id=314611
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314611&action=review

> Source/WebKit2/ChangeLog:3
> +

Extra space here.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4856
> +    if (m_pageClient.shouldSetCursor())

Now that I *see* it, is there any reason for this not just to be folded into
the implementation of setCursor? That addresses Michael's (very minor) concern
and leaves even less madness here.


More information about the webkit-reviews mailing list