[webkit-reviews] review granted: [Bug 174144] REGRESSION: Stack overflow in RenderBlockFlow::layoutBlock after increasing the font size to max in some RTL vertical books. : [Attachment 314591] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 174144: REGRESSION: Stack overflow in RenderBlockFlow::layoutBlock after
increasing the font size to max in some RTL vertical books.
https://bugs.webkit.org/show_bug.cgi?id=174144

Attachment 314591: Patch

https://bugs.webkit.org/attachment.cgi?id=314591&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314591
  --> https://bugs.webkit.org/attachment.cgi?id=314591
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314591&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1732
> +			   // Clear overhanging.

This comment isn't very useful. Maybe say more about why this is necessary?