[webkit-reviews] review granted: [Bug 173988] Add WebKitPrivateFrameworkStubs for iOS 11 : [Attachment 314534] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 173988: Add WebKitPrivateFrameworkStubs for iOS 11
https://bugs.webkit.org/show_bug.cgi?id=173988

Attachment 314534: Patch

https://bugs.webkit.org/attachment.cgi?id=314534&action=review




--- Comment #11 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 314534
  --> https://bugs.webkit.org/attachment.cgi?id=314534
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314534&action=review

r=me

> Source/WebCore/Configurations/WebCore.xcconfig:33
> +

Nit:  Why add a blank line here?  Should be consistent across all *.xcconfig
files.

> Source/WebCore/PAL/Configurations/PAL.xcconfig:32
> +

Nit:  Why add a blank line here?  Should be consistent across all *.xcconfig
files.

> Source/WebKit2/Configurations/BaseTarget.xcconfig:30
> +

Nit:  Why add a blank line here?  Should be consistent across all *.xcconfig
files.

> Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig:37
> +

Nit:  Why add a blank line here?  Should be consistent across all *.xcconfig
files.

>
WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/11/AppSupport.framework/AppSupp
ort.tbd:15
> +exports:
> +  -
> +    archs:
> +	 - armv7
> +	 - armv7s
> +	 - arm64
> +	 - i386
> +  - x86_64

Weird indention here for x86_64.  Does it matter?