[webkit-reviews] review granted: [Bug 174070] REGRESSION (r217522): "Show My Relationship" link in familysearch.org does not work. : [Attachment 314540] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 174070: REGRESSION (r217522): "Show My Relationship" link in
familysearch.org does not work.
https://bugs.webkit.org/show_bug.cgi?id=174070

Attachment 314540: Patch

https://bugs.webkit.org/attachment.cgi?id=314540&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314540
  --> https://bugs.webkit.org/attachment.cgi?id=314540
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314540&action=review

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=174070

Radar number here. Also mention hbr.org

> Source/WebCore/ChangeLog:8
> +	   Decouple in and out of flow computed position values.

"in- and out-of-flow". Mention compat with other browsers.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:794
> +    // Inflow element.

In-flow

> LayoutTests/ChangeLog:8
> +	   * fast/css/getComputedStyle/computed-style-expected.txt:

Does this test exercise all the code paths (out of flow, relative position,
static position, non-block)?

>
LayoutTests/imported/w3c/web-platform-tests/css-timing-1/frames-timing-function
s-output-expected.txt:6
> +FAIL For an input progress of 0.0, the output of a frames timing function is
the first frame assert_equals: expected "0px" but got "auto"
> +FAIL At a frame boundary, the output of a frames timing function is the next
frame assert_equals: expected "0px" but got "auto"
> +FAIL For an input progress of 1.0, the output of a frames timing function is
the final frame assert_equals: expected "100px" but got "auto"
> +FAIL The number of frames is correctly reflected in the frames timing
function output assert_equals: expected "0px" but got "auto"
> +FAIL The number of frames is correctly reflected in the frames timing
function output on CSS Transitions assert_equals: expected "0px" but got
"100px"

It's odd that these are regressing if we now match Chrome behavior.