[webkit-reviews] review granted: [Bug 174109] Receiving tracks should be ended when peer connection is being closed : [Attachment 314535] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 5 07:27:26 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 174109: Receiving tracks should be ended when peer connection is being
closed
https://bugs.webkit.org/show_bug.cgi?id=174109
Attachment 314535: Patch
https://bugs.webkit.org/attachment.cgi?id=314535&action=review
--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 314535
--> https://bugs.webkit.org/attachment.cgi?id=314535
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=314535&action=review
> LayoutTests/webrtc/peer-connection-track-end.html:40
> + setTimeout(() => { reject("onended callbacks too long"); },
5000);
Nit: "callbacks too long" => "callbacks took too long"
More information about the webkit-reviews
mailing list