[webkit-reviews] review granted: [Bug 174143] Crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:] : [Attachment 314588] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ada Chan
<adachan at apple.com>'s request for review:
Bug 174143: Crash in UIKit:  +[UIViewController
_viewControllerForFullScreenPresentationFromView:]
https://bugs.webkit.org/show_bug.cgi?id=174143

Attachment 314588: Patch

https://bugs.webkit.org/attachment.cgi?id=314588&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 314588
  --> https://bugs.webkit.org/attachment.cgi?id=314588
Patch

r=me, this check and the explanation seem reasonable, though I think we still
need a wk2r+. I don't know any simple way to test this, but we could make a
TestWebKitAPI test case that simulates this situation by broadcasting
UIWindowWillRotateNotification after presenting a popover in a WKWebView that's
been removed from its UIWindow.