[webkit-reviews] review granted: [Bug 173397] Web Inspector: Allow users to log any tracked canvas context : [Attachment 314512] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173397: Web Inspector: Allow users to log any tracked canvas context
https://bugs.webkit.org/show_bug.cgi?id=173397

Attachment 314512: Patch

https://bugs.webkit.org/attachment.cgi?id=314512&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314512
  --> https://bugs.webkit.org/attachment.cgi?id=314512
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314512&action=review

Nice! r=me

> LayoutTests/platform/mac/TestExpectations:1145
> +webkit.org/b/174066 inspector/canvas/resolveCanvasContext-webgl2.html [ Pass
Timeout ]
> +webkit.org/b/174066 inspector/canvas/resolveCanvasContext-webgpu.html [ Pass
Timeout ]

Do these really need to be pass timeout as well?

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:-494
> -localizedStrings["Layer"] = "Layer";

Whoa, when did this go away?! Weird.