[webkit-reviews] review granted: [Bug 174079] REGRESSION(Variation Fonts): Specifying Skia by PostScript name does not yield the expected result : [Attachment 314427] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 174079: REGRESSION(Variation Fonts): Specifying Skia by PostScript name
does not yield the expected result
https://bugs.webkit.org/show_bug.cgi?id=174079

Attachment 314427: Patch

https://bugs.webkit.org/attachment.cgi?id=314427&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314427
  --> https://bugs.webkit.org/attachment.cgi?id=314427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314427&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1165
> +	   return {
adoptCF(CTFontCreateWithFontDescriptor(installedFont->fontDescriptor.get(),
size, nullptr)), false };

This false is unnecessary.  Does it help with readability?