[webkit-reviews] review granted: [Bug 172002] webkitpy: Properly number duplicated crashlogs : [Attachment 309926] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 3 09:43:48 PDT 2017
Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 172002: webkitpy: Properly number duplicated crashlogs
https://bugs.webkit.org/show_bug.cgi?id=172002
Attachment 309926: Patch
https://bugs.webkit.org/attachment.cgi?id=309926&action=review
--- Comment #9 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 309926
--> https://bugs.webkit.org/attachment.cgi?id=309926
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=309926&action=review
looks good to me.
> Tools/Scripts/webkitpy/common/system/crashlogs.py:156
> + # Processes can remain running after Sanbox violations,
which generate crash logs.
Typo "Sanbox" => "Sandbox"
More information about the webkit-reviews
mailing list