[webkit-reviews] review granted: [Bug 181176] Remove op_assert and make @assert in builtins a function call so we have DFG/FTL coverage for builtins that use @assert in debug builds : [Attachment 330226] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 181176: Remove op_assert and make @assert in builtins a function call so we
have DFG/FTL coverage for builtins that use @assert in debug builds
https://bugs.webkit.org/show_bug.cgi?id=181176

Attachment 330226: patch

https://bugs.webkit.org/attachment.cgi?id=330226&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 330226
  --> https://bugs.webkit.org/attachment.cgi?id=330226
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330226&action=review

r=me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:875
> +	       return generator.emitLoad(nullptr, jsUndefined());

Let’s load value to dst for consistency. And let’s check ignoreResult so that
we do not need to emit unnecessary mov.