[webkit-reviews] review denied: [Bug 181159] Reduce code duplication between RenderMathMLRow, RenderMathMLEnclose, and RenderMathMLRoot : [Attachment 330220] A preliminary patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 27 09:31:25 PST 2017


Minsheng Liu <lambda at liu.ms> has denied  review:
Bug 181159: Reduce code duplication between RenderMathMLRow,
RenderMathMLEnclose, and RenderMathMLRoot
https://bugs.webkit.org/show_bug.cgi?id=181159

Attachment 330220: A preliminary patch

https://bugs.webkit.org/attachment.cgi?id=330220&action=review




--- Comment #1 from Minsheng Liu <lambda at liu.ms> ---
Created attachment 330220

  --> https://bugs.webkit.org/attachment.cgi?id=330220&action=review

A preliminary patch

This is a preliminary patch illustrating my proposal. It combines code in

* RenderMathMLRow
* RenderMathMLMenclose
* RenderMathMLPadded
* RenderMathMLRoot

There is no regression, but we will need several new test cases.

I did not touch the issue of padding or border as I originally planned. We
probably need Fred to come back to discuss that.

The refactoring process is not completed as many lines can still be improved.
But that could wait for later patches.


More information about the webkit-reviews mailing list