[webkit-reviews] review granted: [Bug 181175] [WTF] Add clock_gettime based monotonicallyIncreasingTime implementation for Linux and BSDs : [Attachment 330214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 27 09:14:08 PST 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 181175: [WTF] Add clock_gettime based monotonicallyIncreasingTime
implementation for Linux and BSDs
https://bugs.webkit.org/show_bug.cgi?id=181175

Attachment 330214: Patch

https://bugs.webkit.org/attachment.cgi?id=330214&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 330214
  --> https://bugs.webkit.org/attachment.cgi?id=330214
Patch

This seems fine to me, since you've ensured that it only affects JSCOnly. GTK
and WPE will be happy that they continue using g_get_monotonic_time, since
WebKit events rely on WebKit's monotonic time matching GLib's. (It should be
the same under the hood -- CLOCK_MONOTONIC -- either way, but continuing to use
g_get_monotonic_time seems preferable.)


More information about the webkit-reviews mailing list