[webkit-reviews] review granted: [Bug 181124] [DFG] Cleaning up and unifying 32bit code more : [Attachment 330116] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 22 11:04:18 PST 2017


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 181124: [DFG] Cleaning up and unifying 32bit code more
https://bugs.webkit.org/show_bug.cgi?id=181124

Attachment 330116: Patch

https://bugs.webkit.org/attachment.cgi?id=330116&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 330116
  --> https://bugs.webkit.org/attachment.cgi?id=330116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330116&action=review

r=me with 32-bit build fix.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1359
> -    JITCompiler::Call callOperation(J_JITOperation_EGReoJ operation, GPRReg
result, GPRReg arg1, GPRReg arg2, GPRReg arg3)
> +    JITCompiler::Call callOperation(J_JITOperation_EGReoJ operation,
JSValueRegs result, GPRReg arg1, GPRReg arg2, JSValueRegs arg3)
>      {
> -	   m_jit.setupArgumentsWithExecState(arg1, arg2, arg3);
> -	   return appendCallSetResult(operation, result);
> +	   m_jit.setupArgumentsWithExecState(arg1, arg2, arg3.payloadGPR());
> +	   return appendCallSetResult(operation, result.payloadGPR());
>      }
>  
> -    JITCompiler::Call callOperation(J_JITOperation_EGReoJss operation,
GPRReg result, GPRReg arg1, GPRReg arg2, GPRReg arg3)
> +    JITCompiler::Call callOperation(J_JITOperation_EGReoJss operation,
JSValueRegs result, GPRReg arg1, GPRReg arg2, GPRReg arg3)
>      {
>	   m_jit.setupArgumentsWithExecState(arg1, arg2, arg3);
> -	   return appendCallSetResult(operation, result);
> +	   return appendCallSetResult(operation, result.payloadGPR());

Looks like these should be USE(JSVALUE64) only.


More information about the webkit-reviews mailing list