[webkit-reviews] review granted: [Bug 181110] Fix build failures due to using deprecated AppKit symbols : [Attachment 330123] Don't spam deprecation guards.

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Wenson Hsieh <wenson_hsieh at apple.com>'s request for
review:
Bug 181110: Fix build failures due to using deprecated AppKit symbols
https://bugs.webkit.org/show_bug.cgi?id=181110

Attachment 330123: Don't spam deprecation guards.

https://bugs.webkit.org/attachment.cgi?id=330123&action=review




--- Comment #24 from mitz at webkit.org ---
Comment on attachment 330123
  --> https://bugs.webkit.org/attachment.cgi?id=330123
Don't spam deprecation guards.

View in context: https://bugs.webkit.org/attachment.cgi?id=330123&action=review

> Source/WebCore/platform/mac/PasteboardMac.mm:-208
> -

Why did we lose this newline?

> Source/WebCore/platform/mac/PasteboardMac.mm:664
> +

Oh, it went here :p

> Source/WebCore/platform/mac/PasteboardWriter.mm:80
> +	   // NSURLPboardType().

?

> Source/WebCore/platform/mac/PasteboardWriter.mm:82
> +	       [pasteboardItem setPropertyList:@[cocoaURL.relativeString,
baseCocoaURL.absoluteString]
forType:toUTI(WebCore::legacyURLPasteboardType()).get()];

Pretty sure the prevailing style is with spaces, similarly to C struct and
array initializers.

> Source/WebKitLegacy/mac/WebView/WebView.h:173
> +    including legacyURLPasteboardType() to find a URL on the pasteboard.

The comments in the API header shouldn’t refer to this WebCore-internal
concept!