[webkit-reviews] review granted: [Bug 181103] importScripts() inside a service worker should ensure that the response has a JavaScript MIME type : [Attachment 330065] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 181103: importScripts() inside a service worker should ensure that the
response has a JavaScript MIME type
https://bugs.webkit.org/show_bug.cgi?id=181103

Attachment 330065: Patch

https://bugs.webkit.org/attachment.cgi?id=330065&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 330065
  --> https://bugs.webkit.org/attachment.cgi?id=330065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330065&action=review

> Source/WebCore/workers/WorkerGlobalScope.cpp:271
>	   // FIXME: Fully implement
https://w3c.github.io/ServiceWorker/#importscripts.

Is this FIXME still relevant? If so, can it be made more precise?

> LayoutTests/imported/w3c/ChangeLog:23
> +	   *
web-platform-tests/service-workers/service-worker/registration-mime-types.https
-expected.txt:

Can we fix the test in this patch and submit a corresponding WPT PR.
If we discover during the PR that we should revert the test change, we could
update our WebKit WPT test and our implementation in a follow-up patch.