[webkit-reviews] review granted: [Bug 181110] Fix build failures due to using deprecated AppKit symbols : [Attachment 330086] Try to fix the build for 10.11

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 21 18:11:12 PST 2017


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 181110: Fix build failures due to using deprecated AppKit symbols
https://bugs.webkit.org/show_bug.cgi?id=181110

Attachment 330086: Try to fix the build for 10.11

https://bugs.webkit.org/attachment.cgi?id=330086&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 330086
  --> https://bugs.webkit.org/attachment.cgi?id=330086
Try to fix the build for 10.11

View in context: https://bugs.webkit.org/attachment.cgi?id=330086&action=review

rs=me once you get the build green

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:860
> +#pragma GCC diagnostic push

why GCC instead of clang :P


More information about the webkit-reviews mailing list