[webkit-reviews] review granted: [Bug 181082] Update Credential Management API for WebAuthentication : [Attachment 330057] Part 1/2

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 181082: Update Credential Management API for WebAuthentication
https://bugs.webkit.org/show_bug.cgi?id=181082

Attachment 330057: Part 1/2

https://bugs.webkit.org/attachment.cgi?id=330057&action=review




--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 330057
  --> https://bugs.webkit.org/attachment.cgi?id=330057
Part 1/2

View in context: https://bugs.webkit.org/attachment.cgi?id=330057&action=review

> Source/WebCore/ChangeLog:3
> +	   [Part 1/2] Update Credential Management API for WebAuthentication

Typically we put the  "Part 1/2" above the "Reviewed by" line and have this
line match the title of the bug verbatim.

> LayoutTests/ChangeLog:9
> +	   * credentials/idlharness-expected.txt:

Should we rename the directory from credentials to credentialmanagement?

> LayoutTests/credentials/idlharness-expected.txt:37
> +FAIL PasswordCredential interface: existence and properties of interface
object assert_own_property: self does not have own property
"PasswordCredential" expected property "PasswordCredential" missing
> +FAIL PasswordCredential interface object length assert_own_property: self
does not have own property "PasswordCredential" expected property
"PasswordCredential" missing
> +FAIL PasswordCredential interface object name assert_own_property: self does
not have own property "PasswordCredential" expected property
"PasswordCredential" missing
> +FAIL PasswordCredential interface: existence and properties of interface
prototype object assert_own_property: self does not have own property
"PasswordCredential" expected property "PasswordCredential" missing
> +FAIL PasswordCredential interface: existence and properties of interface
prototype object's "constructor" property assert_own_property: self does not
have own property "PasswordCredential" expected property "PasswordCredential"
missing
> +FAIL PasswordCredential interface: attribute password assert_own_property:
self does not have own property "PasswordCredential" expected property
"PasswordCredential" missing
> +FAIL PasswordCredential interface: attribute name assert_own_property: self
does not have own property "PasswordCredential" expected property
"PasswordCredential" missing

Would it be bad to remove all the password credential and password
credential-related tests from this file instead of landing expected failure
results?