[webkit-reviews] review granted: [Bug 181094] [RenderTreeBuilder] Move repeating code to RenderTreeBuilder::insertInternal : [Attachment 330046] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 21 11:46:12 PST 2017


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 181094: [RenderTreeBuilder] Move repeating code to
RenderTreeBuilder::insertInternal
https://bugs.webkit.org/show_bug.cgi?id=181094

Attachment 330046: Patch

https://bugs.webkit.org/attachment.cgi?id=330046&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 330046
  --> https://bugs.webkit.org/attachment.cgi?id=330046
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330046&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:65
> +    auto insertInternal = [&](RenderElement& parentCandidate) {

I bet there is a better name somewhere!


More information about the webkit-reviews mailing list