[webkit-reviews] review granted: [Bug 178484] Adopt new secure coding APIs in WebCore : [Attachment 329957] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 21 08:32:47 PST 2017


Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 178484: Adopt new secure coding APIs in WebCore
https://bugs.webkit.org/show_bug.cgi?id=178484

Attachment 329957: Patch

https://bugs.webkit.org/attachment.cgi?id=329957&action=review




--- Comment #52 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 329957
  --> https://bugs.webkit.org/attachment.cgi?id=329957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329957&action=review

> Source/WebCore/ChangeLog:10
> +	   Switch to new NSKeyed[Un]Archiver methods that active and use
> +	   NSSecureCoding by default.

Nit: I don't understand what "... methods that *active* and use ..." means.

> Source/WebCore/PAL/ChangeLog:15
> +	   Rename 'insecurelyUnarchiveObjectOfClassFromData' to match
NSKeyedArchiver naming
> +	   (i.e., 'UnarchivedData' rather than 'UnarchiveData'), and move it
earlier in the
> +	   file so it can be reused by 'unarchiveObjectOfClassFromData'.

Nit: this wording made me think you had renamed
securelyUnarchiveObjectOfClassFromData, not change from
securelyUnarchiveObjectOfClassFromData to
insecurelyUnarchiveObjectOfClassFromData.

Also, I don't understand the new name because the NSKeyedUnarchiver selector is
"unarchiveObjectWithData", not "unarchivedObjectWithData" (no "d").


More information about the webkit-reviews mailing list