[webkit-reviews] review denied: [Bug 181082] Update Credential Management API for WebAuthentication : [Attachment 330026] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 181082: Update Credential Management API for WebAuthentication
https://bugs.webkit.org/show_bug.cgi?id=181082

Attachment 330026: Patch

https://bugs.webkit.org/attachment.cgi?id=330026&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 330026
  --> https://bugs.webkit.org/attachment.cgi?id=330026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330026&action=review

r- because the patch doesn't apply to the current tree (so no ews results), and
because it is very large. Please break it into two steps as I suggest in the
review notes below.

> Source/WebCore/ChangeLog:15
> +	   5. Set runtime flag of Credential Management API in order to enable
testing.

I think this would be easier to review if we did it in steps.

Can you have a "patch 1" that just moves the folder from credentials ->
credentialsmanagement, and removes the useless dummy implementations.
Then, have a "patch 2" that adds new IDLs for WebAuthN, add the new dummy
functions, and add the runtime flag?