[webkit-reviews] review granted: [Bug 181070] [MediaStream] Add screen capture IDL and stub functions : [Attachment 329979] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 181070: [MediaStream] Add screen capture IDL and stub functions
https://bugs.webkit.org/show_bug.cgi?id=181070

Attachment 329979: Patch

https://bugs.webkit.org/attachment.cgi?id=329979&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 329979
  --> https://bugs.webkit.org/attachment.cgi?id=329979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329979&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:270
> +    bool m_isScreenCaptureEnabled {false };

s/{false/{ false/

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:323
> +    case CaptureDevice::DeviceType::Browser:

I was expecting one ScreenCapture DeviceType.
What is the benefit of bringing these in finer grained types?

> LayoutTests/fast/mediastream/screencapture-disabled-expected.txt:1
> +PASS undefined is undefined.

strange message but I guess it is fine.