[webkit-reviews] review granted: [Bug 181061] Crash when clearing std::optional<WebKit::WebServiceWorkerFetchTaskClient::BlobLoader> : [Attachment 329960] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 181061: Crash when clearing
std::optional<WebKit::WebServiceWorkerFetchTaskClient::BlobLoader>
https://bugs.webkit.org/show_bug.cgi?id=181061

Attachment 329960: Patch

https://bugs.webkit.org/attachment.cgi?id=329960&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 329960
  --> https://bugs.webkit.org/attachment.cgi?id=329960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329960&action=review

> Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:117
> -    m_blobLoader = std::nullopt;
> +    auto toDelete = WTFMove(m_blobLoader);

I think it would be better to just do std::exchange(m_blobLoader,
std::nullopt).	Then we wouldn't need to give anything a strange unused name.